DENA-671: Compacted topics validations #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhughes-uw
approved these changes
Oct 28, 2024
rules/msk_topic_config.md
Outdated
Comment on lines
16
to
18
| When cleanup policy is 'compact': | ||
| - 'retention.ms' must not be specified in the config | ||
| - tiered storage must not be enabled |
There was a problem hiding this comment.
I'm not familiar with all these settings, so I'm curious: what's the reason for these restrictions?
EDIT: I see you linked some docs for another change utilitywarehouse/kafka-cluster-config#662 (comment) maybe worth linking those here too?
There was a problem hiding this comment.
Good point, added in this commit: 9a1f2c7
| @@ -42,6 +46,16 @@ resource "kafka_topic" "good topic" { | |||
| "retention.ms" = "86400000" | |||
| } | |||
| } | |||
|
|
|||
| # Good compacted topic | |||
There was a problem hiding this comment.
should there be a bad example here too?
There was a problem hiding this comment.
Sure, it wouldn't hurt. Added in 9a1f2c7
sbuliarca
added a commit
to utilitywarehouse/kafka-cluster-config
that referenced
this pull request
Oct 29, 2024
Updating to utilitywarehouse/tflint-ruleset-kafka-config#27 that includes compacted topics validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validations for compacted topics