DENA-969: Implemented rule for checking the backend #5
Conversation
This reverts commit 43ba7da.
Co-authored-by: Matt Hughes <[email protected]>
Co-authored-by: Matt Hughes <[email protected]>
Co-authored-by: Matt Hughes <[email protected]>
Co-authored-by: Matt Hughes <[email protected]>
sbuliarca
force-pushed
the
add-backend-check
branch
from
da729d3 to
2b2d17c
Compare
…end-check # Conflicts: # README.md # go.mod # go.sum # main.go # rules/terraform_backend_type.go
rules/msk_module_backend.go
Outdated
|
|
||
| // Link returns the rule reference link. | ||
| func (r *MskModuleBackendRule) Link() string { | ||
| return "" |
There was a problem hiding this comment.
Would it be useful to link to this repo/the added README in this directory? (I'm assuming Link is an informative link that shows when the user sees this linter fail)
There was a problem hiding this comment.
Nice catch. I implemented it here: 788cc41
Based on the reference implementation from here: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/main/rules/terraform_comment_syntax.go#L39 , but I dropped the version as that would need constant update, and just used the main blob reference
| if err != nil { | ||
| return fmt.Errorf("emitting issue: backend missing: %w", err) | ||
| } |
There was a problem hiding this comment.
This check looks so odd to me (just a note on the SDK, nothing for us to do): there was an issue running the linter, but we can't show it to you. It would be nice if there was a helper like EmitIssueOrAbort to just end the runner, it's not like there's much we can do to recover 🤷
Co-authored-by: Matt Hughes <[email protected]>
Co-authored-by: Matt Hughes <[email protected]>
See the rule documentation.