tac: add regex flavor translation for compatibility and new test case #10416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 22, 2026
tests/by-util/test_tac.rs
Outdated
| .args(&["-r", "-s", r"[^x]\|x"]) | ||
| .pipe_in("abc") | ||
| .succeeds() | ||
| .stdout_contains("cba"); |
Contributor
There was a problem hiding this comment.
Suggested change
| .stdout_contains("cba"); | |
| .stdout_is("cba"); |
sylvestre
reviewed
Jan 22, 2026
src/uu/tac/src/tac.rs
Outdated
|
|
||
| // Make the regex flavor compatible with `regex` crate | ||
| fn translate_regex_flavor(regex: &str) -> String { | ||
| let result: String = regex.replace("\\|", "|"); |
Contributor
There was a problem hiding this comment.
you only handles \| but BRE has other differences (\(, \), \{, \} for grouping/repetition).
maybe do that now (and add tests)
also unnecessary explicit type annotation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #10320
Added a function to make any necessary translations to input regex in order to make them
regexcompatible.Done to translate
\|into|for now, but should be easy to add any other cases that come up in the future.