Skip to content

Conversation

@Kaua-Klassmann
Copy link
Contributor

Description

This PR fixes the general numeric sort to parse correctly scientific notations with sign

Changes

  • Change "peek_nth(2)" to "peek_nth(1)" on get_leading_gen
  • Add "exponents-positive-general" test to validate general numeric sort

Fixes #10317

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will degrade performance by 7.47%

❌ 1 regressed benchmark
✅ 141 untouched benchmarks
⏩ 180 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_general_numeric[200000] 730.4 ms 789.3 ms -7.47%

Comparing Kaua-Klassmann:fix_scientific_notation_is_incorrectly_parsed_in_general_sort (307305f) with main (d2bd2d3)

Open in CodSpeed

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sort: scientific notation with sign is incorrectly parsed in general numeric sort

1 participant