utmpx.rs: use correct constant names for musl libc#7459
Merged
sylvestre merged 2 commits intouutils:mainfrom Mar 16, 2025
Merged
utmpx.rs: use correct constant names for musl libc#7459sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
Unfortunately, the name of those constants are not standardized: glibc uses __UT_HOSTSIZE, __UT_LINESIZE, __UT_NAMESIZE musl uses UT_HOSTSIZE, UT_LINESIZE, UT_NAMESIZE See: 1. https://git.musl-libc.org/cgit/musl/tree/include/utmpx.h 2. https://github.com/bminor/glibc/blob/master/sysdeps/gnu/bits/utmpx.h#L35 This is a partial fix for uutils#1361 Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
|
GNU testsuite comparison: |
Ecordonnier
force-pushed
the
eco/musl-utmpx
branch
from
29e4582 to
f084b7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the names of those constants are not standardized:
See:
This is a partial fix for #1361