du: use uutils-args to fix some bugs due to usage of clap #7739
+344
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept that using uutils-args would measurably improve compatibility with GNU coreutils, while still passing all existing tests.
Context:
expr
: expr: Get rid of clap for performance reasons #7352du
cli-parser prototype: implement proof of concept for du -bkB uutils-args#114However, this probably shouldn't be merged as-is:
--help
), there are some edge cases it handles wrong: Only sometimes, a late--help
should override other errors uutils-args#130 We should resolve this issue first, as it might change the architecture.#[arg()]
leads to opaque error message uutils-args#129 I don't know enough about proc macros, can someone help here?fn uu_app() -> Command
needs to change. See discord for that discussion; I guess there's going to be vivid discussion.On the other hand, this is a valid approach, and could in theory be used as-is, hence I didn't mark this as "draft".
What do you think?