-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Allow to use any profile from make install #8730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allow to use any profile e.g. `make install PROFILE=release-fast`
Could you please add a check in the ci to make sure we don't regress in the future, thanks |
No idea about what should I test. Everything are installed at same place for each PROFILE... |
GNU testsuite comparison:
|
CodSpeed Performance ReportMerging #8730 will not alter performanceComparing Summary
Footnotes
|
something like this: |
Add test for `make install PROFILE=release-fast`
Included |
GNU testsuite comparison:
|
it regressed a freebsd test:
|
GNU testsuite comparison:
|
This comment was marked as resolved.
This comment was marked as resolved.
`ci` profile is defined at `nextest.toml`. So `make nextest` is needed to use `PROFILE=ci`
GNU testsuite comparison:
|
FreeBSD test started with |
@Ecordonnier Is the file path hardcoded in tests? Is the any idea for it? |
Yes this path is where the file gets installed per default when running make install. |
See #8684 (comment) |
Thankyou for noting about #8684 (comment) . |
Yes |
GNU testsuite comparison:
|
GNU testsuite comparison:
|
GNU testsuite comparison:
|
GNU testsuite comparison:
|
Test passed by adding workaround for it. Not great, but this is ready for merge. |
GNU testsuite comparison:
|
Allow to use any profile at
make
e.g.make install PROFILE=release-fast
.