-
Notifications
You must be signed in to change notification settings - Fork 3
New Processing Task NemoYearMeanTimeseries #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes #107 - created a new task + documentation + tests - removed requirement for NemoTimeseries to take a domain argument (only required for GlobalMean and GlobalSum tasks)
I have now updated the test to use a new test file for scalar output which I added to the test data repository. It seems like my original test (where I created some dummy data with the correct time coordinates) checked all the boxes but it feels more robust to use a file that was actually created by NEMO (also, it is quite small). So, ready for review! Also @vlap feel free to let me know if anything seems off. |
all looks great. Thank you once again! |
@uwefladrich are these changes fine with you as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me, nice work! 👍
thanks again, @valentinaschueller and @uwefladrich Can I start using it in ece4? Will it work without any changes in our
|
That's the idea, this feature is part of the latest version of Edit: Latest version is on conda-forge now as well 🙂 |
fixes #107
@vlap Does this look like what you asked for?