Skip to content

New Processing Task NemoYearMeanTimeseries #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

valentinaschueller
Copy link
Collaborator

@valentinaschueller valentinaschueller commented Feb 18, 2025

fixes #107

  • created a new task + documentation + tests
  • removed requirement for NemoTimeseries to take a domain argument (only required for GlobalMean and GlobalSum tasks)

@vlap Does this look like what you asked for?

fixes #107
- created a new task + documentation + tests
- removed requirement for NemoTimeseries to take a domain argument (only required for GlobalMean and GlobalSum tasks)
@valentinaschueller valentinaschueller marked this pull request as ready for review February 19, 2025 11:58
@valentinaschueller
Copy link
Collaborator Author

I have now updated the test to use a new test file for scalar output which I added to the test data repository. It seems like my original test (where I created some dummy data with the correct time coordinates) checked all the boxes but it feels more robust to use a file that was actually created by NEMO (also, it is quite small).

So, ready for review! Also @vlap feel free to let me know if anything seems off.

@vlap
Copy link

vlap commented Feb 19, 2025

all looks great. Thank you once again!

@valentinaschueller
Copy link
Collaborator Author

@uwefladrich are these changes fine with you as well?

Copy link
Owner

@uwefladrich uwefladrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, nice work! 👍

@valentinaschueller valentinaschueller merged commit 3bde5f3 into master Feb 26, 2025
22 checks passed
@valentinaschueller valentinaschueller deleted the feature/nemo-year-mean-timeseries branch February 26, 2025 12:16
@vlap
Copy link

vlap commented Feb 27, 2025

thanks again, @valentinaschueller and @uwefladrich

Can I start using it in ece4? Will it work without any changes in our environment.yml, just by updating conda env? We have

dependencies:
  - scriptengine-tasks-ecearth  # Needed for ECE4 monitoring only!

@valentinaschueller
Copy link
Collaborator Author

valentinaschueller commented Feb 27, 2025

Can I start using it in ece4?

That's the idea, this feature is part of the latest version of scriptengine-tasks-ecearth (v0.7.0), so updating your environment should do it. It is already updated on PyPI and the latest version should appear on conda-forge soon, I would assume sometime today. You can check whether the new tasks are available by running se --help

Edit: Latest version is on conda-forge now as well 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a NemoYearMeanTimeseries task which assumes 1D input data
3 participants