feat(lune): add optional farm build to lune #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twnlink
force-pushed
the
experimental_farm
branch
from
3df0fce
to
816f313
Compare
yellowsink
requested changes
Aug 5, 2024
| "readline/promises", | ||
| ], | ||
| platform: "node", | ||
| }); |
There was a problem hiding this comment.
We need to bundle the solid compiler due to npm's inability to pin deps-of-deps so this change is a no-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces optional Farm support for Vite / Rollup plugin compatibility.
Building with Farm is currently reliant on esbuild for the final build step unfortunately due to the way
vite-plugin-solidworks.Farm support does not include SCSS out of the box due to being unable to get the official Farm Rust plugin working, but it should be doable via a Vite / Rollup plugin.
Ideally we could eventually resolve both of these issues and remove the dependency on
esbuild, which should theoretically make plugin building faster.