-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] use sklearnex azure pipelines template for sklearnex CI step #2950
[CI] use sklearnex azure pipelines template for sklearnex CI step #2950
Conversation
/intelci: run |
/intelci: run |
function install_mkl { | ||
sudo apt-get install -y intel-oneapi-mkl-devel-2025.0 intel-oneapi-tbb-devel-2022.0 | ||
sudo apt-get install -y intel-oneapi-mkl-devel-2025.0 | ||
install_tbb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be called here? May be its better to call both functions? And why we must include it in MKL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question @Alexandr-Solovev, why tbb install was included in mkl I do not know (included in the 2025.0 update I think), but I called one function in the other so that we only have to change the tbb version in one location going forward. Let me know if I should change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current changes look good for me
Description
oneDAL should refer to sklearnex's testing rather than storing scripts on its own locally. This is a maintenance burden that we can remove. No performance benchmarks are necessary. This PR has been enabled by uxlfoundation/scikit-learn-intelex#2125 in order to use the PR-generated GNUMKL build.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance