Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] use sklearnex azure pipelines template for sklearnex CI step #2950

Merged
merged 45 commits into from
Dec 10, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 22, 2024

Description

oneDAL should refer to sklearnex's testing rather than storing scripts on its own locally. This is a maintenance burden that we can remove. No performance benchmarks are necessary. This PR has been enabled by uxlfoundation/scikit-learn-intelex#2125 in order to use the PR-generated GNUMKL build.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust icfaust added the infra label Oct 28, 2024
@icfaust icfaust marked this pull request as ready for review October 28, 2024 20:38
@icfaust icfaust marked this pull request as draft October 28, 2024 20:38
@icfaust
Copy link
Contributor Author

icfaust commented Nov 4, 2024

/intelci: run

@icfaust icfaust marked this pull request as ready for review December 6, 2024 06:15
@icfaust
Copy link
Contributor Author

icfaust commented Dec 6, 2024

/intelci: run

.ci/env/apt.sh Outdated Show resolved Hide resolved
function install_mkl {
sudo apt-get install -y intel-oneapi-mkl-devel-2025.0 intel-oneapi-tbb-devel-2022.0
sudo apt-get install -y intel-oneapi-mkl-devel-2025.0
install_tbb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be called here? May be its better to call both functions? And why we must include it in MKL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question @Alexandr-Solovev, why tbb install was included in mkl I do not know (included in the 2025.0 update I think), but I called one function in the other so that we only have to change the tbb version in one location going forward. Let me know if I should change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current changes look good for me

@icfaust icfaust merged commit a38140a into uxlfoundation:main Dec 10, 2024
18 of 20 checks passed
@icfaust icfaust deleted the dev/use_sklearnex_testing branch December 10, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants