Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI jobs for OpenRNG-OpenBLAS-Arm build #2972

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DhanusML
Copy link
Contributor

@DhanusML DhanusML commented Nov 8, 2024

Description

  • Added new CI job for the OpenRNG build
  • Modified the build script to enable cross compile
  • Fixed static link build issue with Openrng backend
  • Extended excluded examples for OpenRNG build

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

* Modified the build script to enable cross compile
* Fixed static link build with openrng backend
* Extended exclude list for openrng build

Signed-off-by: Dhanus M Lal <[email protected]>
Signed-off-by: Dhanus M Lal <[email protected]>
@icfaust
Copy link
Contributor

icfaust commented Nov 9, 2024

@DhanusML is there a way to integrate the OpenRNG testing into another job or replace another? we are becoming very resource constrained in azure pipelines and github actions.

@ethanglaser ethanglaser requested a review from Vika-F December 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants