-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add NO_DIST to sklearnex workload #2992
base: main
Are you sure you want to change the base?
Conversation
Looks like the env. variable
That being said, the examples are also executed as part of the tests anyway, so you could remove them entirely from the CI. |
@david-cortes-intel green now - but I see recent OneDAL PRs do not have this public CI failure - was something else changed to fix this? |
No changes that I'm aware of. Odd that it just randomly failed for one specific PR that didn't touch the .yaml files. Nevertheless, it wouldn't hurt to remove the custom |
Description
Fix for public CI (LinuxSklearnex Python311)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing