Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add NO_DIST to sklearnex workload #2992

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Nov 27, 2024

Description

Fix for public CI (LinuxSklearnex Python311)


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

.ci/pipeline/ci.yml Outdated Show resolved Hide resolved
@david-cortes-intel
Copy link
Contributor

Looks like the env. variable NO_DIST=1 worked for the tests, but arg --nodist didn't work for the examples:

Traceback (most recent call last):
  File "/home/vsts/work/1/s/sklearnex/examples/daal4py/naive_bayes_spmd.py", line 36, in <module>
    talgo = d4p.multinomial_naive_bayes_training(20, distributed=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "build/daal4py_cy.pyx", line 17656, in daal4py._daal4py.multinomial_naive_bayes_training.__cinit__
TypeError: __cinit__() got an unexpected keyword argument 'distributed'

That being said, the examples are also executed as part of the tests anyway, so you could remove them entirely from the CI.

.ci/pipeline/ci.yml Outdated Show resolved Hide resolved
@ethanglaser
Copy link
Contributor Author

Looks like the env. variable NO_DIST=1 worked for the tests, but arg --nodist didn't work for the examples:

Traceback (most recent call last):
  File "/home/vsts/work/1/s/sklearnex/examples/daal4py/naive_bayes_spmd.py", line 36, in <module>
    talgo = d4p.multinomial_naive_bayes_training(20, distributed=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "build/daal4py_cy.pyx", line 17656, in daal4py._daal4py.multinomial_naive_bayes_training.__cinit__
TypeError: __cinit__() got an unexpected keyword argument 'distributed'

That being said, the examples are also executed as part of the tests anyway, so you could remove them entirely from the CI.

@david-cortes-intel green now - but I see recent OneDAL PRs do not have this public CI failure - was something else changed to fix this?

@david-cortes-intel
Copy link
Contributor

Looks like the env. variable NO_DIST=1 worked for the tests, but arg --nodist didn't work for the examples:

Traceback (most recent call last):
  File "/home/vsts/work/1/s/sklearnex/examples/daal4py/naive_bayes_spmd.py", line 36, in <module>
    talgo = d4p.multinomial_naive_bayes_training(20, distributed=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "build/daal4py_cy.pyx", line 17656, in daal4py._daal4py.multinomial_naive_bayes_training.__cinit__
TypeError: __cinit__() got an unexpected keyword argument 'distributed'

That being said, the examples are also executed as part of the tests anyway, so you could remove them entirely from the CI.

@david-cortes-intel green now - but I see recent OneDAL PRs do not have this public CI failure - was something else changed to fix this?

No changes that I'm aware of. Odd that it just randomly failed for one specific PR that didn't touch the .yaml files.

Nevertheless, it wouldn't hurt to remove the custom run_examples.py from the pipelines here, considering that those are still getting executed through the pytest scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants