Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coverity hits for PCA #3025

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

KateBlueSky
Copy link

@KateBlueSky KateBlueSky commented Dec 16, 2024

Description

Fixed the "copy without assign" issues for PCA

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@KateBlueSky KateBlueSky changed the title Dev pca coverity hits Fix Coverity hits for PCA Dec 16, 2024
@KateBlueSky
Copy link
Author

/intelci: run

@KateBlueSky
Copy link
Author

/intelci: run

@KateBlueSky KateBlueSky marked this pull request as ready for review December 18, 2024 14:59
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, one minor comment about comment

@KateBlueSky
Copy link
Author

/intelci: run

@@ -200,6 +200,7 @@ class DAAL_EXPORT Input : public InputIface
public:
Input();
Input(const Input & other);
Input & operator=(const Input & other) = delete;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should not be deleted, as Input objects are copyable by design:

Suggested change
Input & operator=(const Input & other) = delete;
Input & operator=(const Input & other);

Please add the implementation (can be = default;) in this .cpp file:
https://github.com/uxlfoundation/oneDAL/blob/main/cpp/daal/src/algorithms/pca/pca_input.cpp

The same applies to DistributedInput and ResultImpl.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be resolved now.

@KateBlueSky
Copy link
Author

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants