-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Coverity hits for PCA #3025
base: main
Are you sure you want to change the base?
Fix Coverity hits for PCA #3025
Conversation
/intelci: run |
…y/oneDAL into dev_pca_coverity_hits
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, one minor comment about comment
/intelci: run |
@@ -200,6 +200,7 @@ class DAAL_EXPORT Input : public InputIface | |||
public: | |||
Input(); | |||
Input(const Input & other); | |||
Input & operator=(const Input & other) = delete; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those should not be deleted, as Input
objects are copyable by design:
Input & operator=(const Input & other) = delete; | |
Input & operator=(const Input & other); |
Please add the implementation (can be = default;
) in this .cpp file:
https://github.com/uxlfoundation/oneDAL/blob/main/cpp/daal/src/algorithms/pca/pca_input.cpp
The same applies to DistributedInput
and ResultImpl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be resolved now.
/intelci: run |
Description
Fixed the "copy without assign" issues for PCA
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance