Add proper CPUID eax checking #3026
Conversation
This makes it possible to use the sse42, avx2 code paths on AMD processors
| @@ -71,6 +71,19 @@ void run_cpuid(uint32_t eax, uint32_t ecx, uint32_t * abcd) | |||
| #endif | |||
| } | |||
|
|
|||
| uint32_t __daal_internal_get_max_extension_support() | |||
There was a problem hiding this comment.
This function is not necessary, it can be folded in below.
There was a problem hiding this comment.
This follows the pattern of __daal_internal_is_intel_cpu and daal_check_is_intel_cpu where the former is the one that does the work and the latter is there to cache the value in a static variable to avoid running the former multiple times.
| @@ -71,6 +71,19 @@ void run_cpuid(uint32_t eax, uint32_t ecx, uint32_t * abcd) | |||
| #endif | |||
| } | |||
|
|
|||
| uint32_t __daal_internal_get_max_extension_support() | |||
| { | |||
| uint32_t abcd[4]; | |||
There was a problem hiding this comment.
clearer naming is necessary.
There was a problem hiding this comment.
The naming used is abcd throughout this file. This variable stores the values of the eax, ebx, ecx, edx registers just like the other functions. Any ideas on what to rename all of them to?
| uint32_t __daal_internal_get_max_extension_support() | ||
| { | ||
| uint32_t abcd[4]; | ||
| run_cpuid(0x80000000, 0, abcd); |
There was a problem hiding this comment.
commentary for this would be nice.
| @@ -193,7 +211,7 @@ static int check_sse42_features() | |||
|
|
|||
| DAAL_EXPORT bool __daal_serv_cpu_extensions_available() | |||
| { | |||
| return daal_check_is_intel_cpu(); | |||
| return 1; | |||
There was a problem hiding this comment.
First, if a bool, it would be best to return a bool. Secondly, if this is a no-op, then the function should be removed.
There was a problem hiding this comment.
I removed the function and its usages.
|
Thanks for the review @icfaust |
This makes it possible to use the sse42, avx2 code paths on AMD processors
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance