-
Notifications
You must be signed in to change notification settings - Fork 116
Update the tested Standard C++ APIs for libc++
#2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tested Standard C++ APIs for libc++
#2080
Conversation
libc++
from tested APIlibc++
from tested Standard C++ APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fair to me. I confirm that libc++ is not regularly tested.
We can update the table again after testing it manually or setting up automatic testing.
I would suggest waiting for others' opinions, though.
Was this gap introduced when the clang++ driver was removed from the DPC++ compiler distribution? I think in order to test with the clang++ driver we would need to use a build of the https://github.com/intel/llvm. |
https://www.intel.com/content/www/us/en/developer/articles/troubleshooting/sourcing-oneapi-overrides-existing-clang-drivers.html : "The oneAPI provided clang/clang++ drivers were not intended to be used by customers..." |
@timmiesmith can this patch be retargeted to 2022.8 (and the respective branch) instead, or is it already late? |
I think we're too late for inclusion in the oneAPI 2025.1 release, but we can pull this into the 2022.8.0 release branch so the open source release has the correct status. |
I have prepared separate PR #2086 for 2022.8 |
442e5e0
to
20c144d
Compare
42b80d3
to
d18a4c8
Compare
009fcad
to
a6c7b30
Compare
a84025a
to
b16d92e
Compare
dea8c21
to
ba73766
Compare
ba73766
to
b66dd54
Compare
e8e78de
to
6c7e568
Compare
libc++
from tested Standard C++ APIslibc++
…api.rst - add compiler name
documentation/library_guide/api_for_sycl_kernels/tested_standard_cpp_api.rst
Outdated
Show resolved
Hide resolved
…api.rst - add Intel compiler name
…api.rst - change compiler to Compiler
…api.rst - set Clang* Clang* 18.1, Clang* 19.1, Clang* 20.1 for libc++ (LLVM)
…api.rst - fix AdaptiveCpp compiler name
…api.rst - fix review
…api.rst - some tests of std::complex failed
Done. |
…api.rst - fix text
a8089c7
to
73c8cc4
Compare
documentation/library_guide/api_for_sycl_kernels/tested_standard_cpp_api.rst
Outdated
Show resolved
Hide resolved
…rd_cpp_api.rst Co-authored-by: Dmitriy Sobolev <[email protected]>
documentation/library_guide/api_for_sycl_kernels/tested_standard_cpp_api.rst
Outdated
Show resolved
Hide resolved
…api.rst - fix review comment
documentation/library_guide/api_for_sycl_kernels/tested_standard_cpp_api.rst
Outdated
Show resolved
Hide resolved
…rd_cpp_api.rst Co-authored-by: Dmitriy Sobolev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As before, I suggest waiting for others' opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
@dmitriy-sobolev, thanks a lot for preparing test environment and you comments during review! |
In this PR we marked tests functions of
libc++
Standard C++ APIs, which works in Kernel code in AdaptiveCpp compiler.