Indirectly Device Accessible Iterator Trait and ADL Customization Point #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhoeflinger
force-pushed
the
dev/dhoeflin/passed_directly_trait
branch
from
ccc2347 to
b159f2e
Compare
danhoeflinger
changed the title
danhoeflinger
changed the title
danhoeflinger
requested review from
timmiesmith,
MikeDvorskiy,
mmichel11,
adamfidel,
reble,
akukanov,
rarutyun and
dmitriy-sobolev
danhoeflinger
changed the title
danhoeflinger
force-pushed
the
dev/dhoeflin/passed_directly_trait
branch
from
d07a3a2 to
2bf81cc
Compare
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
…ant code Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
force-pushed
the
dev/dhoeflin/passed_directly_trait
branch
from
0da03d0 to
ef96683
Compare
Signed-off-by: Dan Hoeflinger <[email protected]>
MikeDvorskiy
reviewed
May 5, 2025
| @@ -398,6 +450,10 @@ class zip_iterator | |||
| return !(*this < __it); | |||
| } | |||
|
|
|||
| friend auto | |||
| is_onedpl_indirectly_device_accessible_iterator(const zip_iterator&) | |||
There was a problem hiding this comment.
Just a couple of questions.
Do we have some risk that we use not fully qualified name for zip_iterator?
Do we have some risk that something zip_iterator value (with qualificators) doesn't
match to const zip_iterator&?
There was a problem hiding this comment.
Since this is a hidden friend, we are using the current exact instantiated type of zip_iterator here.
As for const zip_iterator&, I suppose that we should just use zip_iterator. Copies don't matter because this is only used at compile time to determine output type. I've adjusted all of these ADL overloads to just use the type itself without reference.
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
MikeDvorskiy
reviewed
May 5, 2025
test/parallel_api/iterator/indirectly_device_accessible.pass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Hoeflinger <[email protected]>
MikeDvorskiy
reviewed
May 5, 2025
test/general/implementation_details/indirectly_device_accessible.pass.cpp
Outdated
Show resolved
Hide resolved
MikeDvorskiy
reviewed
May 5, 2025
test/general/implementation_details/indirectly_device_accessible.pass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
mmichel11
previously approved these changes
May 5, 2025
Signed-off-by: Dan Hoeflinger <[email protected]>
mmichel11
approved these changes
May 5, 2025
timmiesmith
pushed a commit
that referenced
this pull request
Jun 9, 2025
…nt (#2126) --------- Signed-off-by: Dan Hoeflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types are "Indirectly Device Accessible" when they can represent data which can inherently be dereferenced in a SYCL kernel. Marking types as such can help oneDPL avoid unnecessary data movement surrounding sycl kernels.
Provides a default implementation for the Argument-Dependant Lookup (ADL) customization point
is_onedpl_indirectly_device_accessible, as well as defined ADL overloads for oneDPL's provided iterators to provide rules for when they should be considered "indirectly device accessible".Provides a public trait,
is_indirectly_device_accessible[_v]which can be used to query whether a type is "indirectly device accessible". This can be used in combination withsycl::is_device_copyableand a check that it is a random access iterator to determine if it can be passed directly into sycl kernels without extra logic to copy the data to the device.PR implementing the proposed design in #1999, and the current state of specification PR uxlfoundation/oneAPI-spec#620.
Will not merge until specification has been merged.