Correct deprecation syntax of oneapi::dpl::experimental::kt::esimd namespace #2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including
<oneapi/dpl/experimental/kernel_templates>
with newer compilers, I see the following compilation error:According to https://en.cppreference.com/w/cpp/language/attributes/deprecated, it appears the proper syntax to deprecate a namespace is
namespace [[deprecated]] NS { ... }
. Our deprecation attribute is provided after the namespace's name which appears incorrect.After correcting this, I see the proper warning when trying to compile using the deprecated namespace:
The placement of the attribute after the namespace seems to be a new error in clang which can be seen on trunk, an error with MSVC, and a warning with gcc when compiling with
-Wpedantic
: https://godbolt.org/z/xo4YfPKqo