Different types of result and temporary data in __result_and_scratch_storage
#2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
6 times, most recently
from
ff742d8 to
2fea5f1
Compare
SergeyKopienko
changed the title
__result_and_scratch_storage
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
from
2fea5f1 to
99a9881
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
3 times, most recently
from
5acd3f9 to
a2e327f
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
4 times, most recently
from
b7cd789 to
9b9bfe6
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
4 times, most recently
from
dfc37db to
577a5ff
Compare
…hared_ptr<__result_and_scratch_storage_base>
…nique_ptr<__result_and_scratch_storage_base>
…add ability to move sycl::event into __future constructor
…orage + fix usages
…extract from __result_and_scratch_storage internal implementation __result_and_scratch_storage_impl
…extract from __result_and_scratch_storage internal implementation __result_and_scratch_storage_impl - move up some internal data
…extract from __result_and_scratch_storage internal implementation __result_and_scratch_storage_impl - move __sycl_usm_alloc and __sycl_usm_free into __result_and_scratch_storage_impl and save sycl::queue& instead of instance
…extract from __result_and_scratch_storage internal implementation __result_and_scratch_storage_impl - remove __result_and_scratch_storage_data_ptr_t type
…extract from __result_and_scratch_storage internal implementation __result_and_scratch_storage_impl - pass sycl::queue by reference into result_and_scratch_storage
…remove extra else
…introduce __create_usm_buffer and remove some duplicated code
…rename is_USM() to __has_supports_USM_device()
…refactoring of __use_USM_host_allocations()
…remove extra else in __future::get() method
…remove extra else in __future::__get_data() method
…remove extra __future::__future(...)
…fix compile errors
…implementation if USM / Sycl buffers placement based on std::variant
…move the definition of __usm_or_buffer_accessor into __result_and_scratch_storage
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_result_and_scratch_storage
branch
from
577a5ff to
7b155ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we implements the ability to have different types of result and temporary data in result and scratch storage.
Also all
std::shared_ptrhas been replaced bystd::unique_ptr.__result_and_scratch_storagehas been refactored and implemented onpimpl-implementation.