Skip to content

Conversation

@alan-forbes-cp
Copy link
Collaborator

@alan-forbes-cp alan-forbes-cp commented Mar 10, 2025

Overview

Update Windows PR test to build via LLVM github release 'download & extract' (rather than cache)

Reason for change

First use of non-cache for windows (previously hard-wired).
First use of download&extract Github LLVM artefacts.

Description of change

  • Use Github download/extract artefacts for Windows PR jobs.
  • Update llvm_version setting to incorporate downloads from llvm-release.
  • Work-around hard-wired reference to VS "Professional" lib (when "Enterprise" is actually installed)
  • Fix pull_request: param - should be is_pull_request:

Anything else we should know?

The test to which this PR refers was blocked by the following issue: https://codeplaysoft.atlassian.net/browse/OR-750
Now unblocked.

@alan-forbes-cp alan-forbes-cp changed the title DRAFT: github windows llvm release download DRAFT: github llvm release download Mar 12, 2025
@alan-forbes-cp alan-forbes-cp changed the title DRAFT: github llvm release download DRAFT: Run Windows PR test via github llvm release download Mar 13, 2025
@alan-forbes-cp alan-forbes-cp changed the title DRAFT: Run Windows PR test via github llvm release download Run Windows PR test via github llvm release download Mar 13, 2025
@alan-forbes-cp alan-forbes-cp marked this pull request as ready for review March 13, 2025 17:08
@alan-forbes-cp alan-forbes-cp requested a review from a team as a code owner March 13, 2025 17:08
coldav pushed a commit to coldav/oneapi-construction-kit that referenced this pull request Apr 16, 2025
This resolves previous failures, but dropping 32 bit x86 caching
and commenting out the windows seeding.

Note the windows seeding should be restored as soon as PR uxlfoundation#707 is merged.
coldav pushed a commit to coldav/oneapi-construction-kit that referenced this pull request Apr 16, 2025
This resolves previous failures, but dropping 32 bit x86 caching
and commenting out the windows seeding.

Note the windows seeding should be restored as soon as PR uxlfoundation#707 is merged.
@alan-forbes-cp alan-forbes-cp force-pushed the alan/OR-745_windows_llvm_release_download branch from e5fa1c5 to 286e009 Compare April 16, 2025 15:36
@alan-forbes-cp alan-forbes-cp force-pushed the alan/OR-745_windows_llvm_release_download branch from 44e21bd to fb30330 Compare April 28, 2025 14:06
@alan-forbes-cp alan-forbes-cp requested a review from coldav April 28, 2025 15:50
@alan-forbes-cp alan-forbes-cp requested a review from coldav May 1, 2025 08:50
@alan-forbes-cp alan-forbes-cp merged commit a60afd7 into uxlfoundation:main May 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants