Add AppStreams to SSM #11135

wweellddeerr · 2025-11-05T19:35:40Z

What does this PR change?

This PR introduces AppStreams configuration feature to SSM through WebUI and API.

Codespace

Check if you already have a running container clicking on

GUI diff

After:

DONE

Documentation

No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Multi-Linux Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24196

DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

Re-run test "changelog_test"
Re-run test "backend_unittests_pgsql"
Re-run test "java_pgsql_tests"
Re-run test "schema_migration_test_pgsql"
Re-run test "susemanager_unittests"
Re-run test "frontend_checks"
Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

github-actions · 2025-11-05T19:36:04Z

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/11135/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/11135/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

web/html/src/manager/systems/appstreams/ssm-appstreams-configure.tsx

web/html/src/manager/systems/appstreams/ssm-appstreams-channel-selection.tsx

web/html/src/manager/systems/appstreams/ssm-appstreams-configure-list.tsx

Etheryte · 2025-11-11T09:17:32Z

web/html/src/manager/systems/appstreams/ssm-appstreams-channel-selection.tsx

+                <>
+                  {row.parentId && (
+                    <img
+                      style={{ marginLeft: "4px", marginRight: "8px", verticalAlign: "middle" }}


Instead of inline styles, it would be preferable to use a css module, see e.g. web/html/src/components/table/SearchPanel.module.scss and web/html/src/components/table/SearchPanel.tsx.

Etheryte

Thank you very much for the updates, LGTM. 👍

cbbayburt

I left a couple of questions below to clarify, but overall it looks good to me 👍

One thing though; not strictly necessary, but since we're not in a rush, could you add a shortcut link to the SSM Overview tab like the others?

java/code/src/com/redhat/rhn/manager/ssm/SsmManager.java

java/code/src/com/suse/manager/webui/controllers/appstreams/AppStreamsController.java

cbbayburt

Meanwhile, I deployed the code and tested it manually. It works great!

I only have one more request below regarding RBAC.

schema/spacewalk/common/data/endpointNamespace.sql

cbbayburt · 2025-11-19T13:58:05Z

schema/spacewalk/common/data/namespace.sql

+INSERT INTO access.namespace (namespace, access_mode, description)
+    VALUES ('systems.appstreams', 'W', 'Manage AppStreams on systems (SSM)')
+    ON CONFLICT (namespace, access_mode) DO NOTHING;


Since we're going to use the existing systems.software.appstreams namespace, you don't need to insert anything to the namespace table.

Suggested change

INSERT INTO access.namespace (namespace, access_mode, description)

VALUES ('systems.appstreams', 'W', 'Manage AppStreams on systems (SSM)')

ON CONFLICT (namespace, access_mode) DO NOTHING;

BTW, if we were going to use a namespace, you would need to add a row into the accessgroupnamespace table for each access group that should have access to the new namespace by default.

If you don't add the namespace to any access group, effectively, only Uyuni admin (not even org admin) can access the namespace.

You don't need to do this for existing namespaces, unless you want to change the default access rules for them for some reason.

- Update migration script to use the existing 'systems.software.appstreams' RBAC namespace instead of creating a new one. - Fix typo in the endpoint path within the migration script. - Remove unnecessary DISTINCT clause from LIST_SSM_SERVERS_IN_CHANNEL_SQL query. - Rename 'getAppStreamChannelFromPath' to 'resolveAppStreamChannel'. - Change invalid channel handling to use 'response.redirect' instead of a server-side forward, ensuring the URL matches the view. - Add a shortcut link to the SSM Overview tab.

cbbayburt · 2025-11-21T10:20:19Z

Thanks for addressing my comments, @wweellddeerr.

I have just one final suggestion:

For RBAC, we have this new ACL called authorized_for(<namespace>) that renders parts of the JSP conditionally, only if the user has access to the specific namespace. We don't have it everywhere, but I've been trying to use it as much as possible, especially when adding new stuff.

With this ACL, we can let the AppStreams tab render only if the user has access to systems.software.appstreams, so we can avoid 403 links as much as we can.

Here's some examples:

SSM tabs:

uyuni/java/code/webapp/WEB-INF/nav/ssm.xml

Lines 27 to 29 in 8c6139b

    
           <rhn-tab name="Product Migration" acl="authorized_for(systems.software.migration); all_systems_in_set_have_feature(ftr_package_updates)"> 
        
               <rhn-tab-url>/rhn/manager/systems/ssm/product-migration</rhn-tab-url> 
        
           </rhn-tab>

SSM index page shortcuts:

uyuni/java/code/webapp/WEB-INF/pages/ssm/ssmindex.jsp

Lines 68 to 80 in 8c6139b

    
           <rhn:require acl="authorized_for(systems.software.migration); all_systems_in_set_have_feature(ftr_package_updates)"> 
        
               <li class="list-group-item"> 
        
                   <div class="row"> 
        
                       <div class="col-sm-2"> 
        
                         <rhn:icon type="header-channel" title="ssm.overview.product_migration" /> 
        
                           <bean:message key="ssm.overview.product_migration"/> 
        
                       </div> 
        
                       <div class="col-sm-10"> 
        
                           <bean:message key="ssm.overview.product_migration.migrate"/> 
        
                       </div> 
        
                   </div> 
        
               </li> 
        
           </rhn:require>

wweellddeerr requested review from a team as code owners November 5, 2025 19:35

wweellddeerr requested review from parlt91 and removed request for a team November 5, 2025 19:35

github-actions bot added java java_lint_checkstyle java_pgsql_tests API schema_migration_test_pgsql database schema_migration_test_oracle ui webapp old-ui webui-templates frontend_checks labels Nov 5, 2025

github-actions bot added the needs-translation label Nov 5, 2025

wweellddeerr force-pushed the ssm-appstreams branch 2 times, most recently from 4006ebd to 31f057b Compare November 5, 2025 22:30

Etheryte reviewed Nov 6, 2025

View reviewed changes

web/html/src/manager/systems/appstreams/ssm-appstreams-configure.tsx Outdated Show resolved Hide resolved

Etheryte reviewed Nov 6, 2025

View reviewed changes

web/html/src/manager/systems/appstreams/ssm-appstreams-channel-selection.tsx Outdated Show resolved Hide resolved

Etheryte reviewed Nov 6, 2025

View reviewed changes

web/html/src/manager/systems/appstreams/ssm-appstreams-channel-selection.tsx Outdated Show resolved Hide resolved

Etheryte reviewed Nov 6, 2025

View reviewed changes

web/html/src/manager/systems/appstreams/ssm-appstreams-configure-list.tsx Outdated Show resolved Hide resolved

wweellddeerr force-pushed the ssm-appstreams branch 3 times, most recently from 2e3c3fa to 1f40aea Compare November 10, 2025 23:38

Etheryte reviewed Nov 11, 2025

View reviewed changes

Etheryte previously approved these changes Nov 11, 2025

View reviewed changes

wweellddeerr dismissed Etheryte’s stale review via bfab440 November 17, 2025 12:20

wweellddeerr force-pushed the ssm-appstreams branch from 1f40aea to bfab440 Compare November 17, 2025 12:20

github-actions bot added the xmlrpc label Nov 17, 2025

wweellddeerr requested a review from cbbayburt November 17, 2025 12:21

wweellddeerr force-pushed the ssm-appstreams branch from bfab440 to b57d0bf Compare November 17, 2025 12:32

cbbayburt requested changes Nov 19, 2025

View reviewed changes

wweellddeerr added 4 commits November 19, 2025 22:50

Add AppStreams to SSM

2cd4ea3

Improve usage of table related React components

982bded

Add SSM AppStreams API methods

397170f

wweellddeerr force-pushed the ssm-appstreams branch from b57d0bf to 781ca87 Compare November 20, 2025 01:52

	INSERT INTO access.namespace (namespace, access_mode, description)
	VALUES ('systems.appstreams', 'W', 'Manage AppStreams on systems (SSM)')
	ON CONFLICT (namespace, access_mode) DO NOTHING;

Add AppStreams to SSM #11135

Are you sure you want to change the base?

Add AppStreams to SSM #11135

Uh oh!

Conversation

wweellddeerr commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR change?

Codespace

GUI diff

Documentation

Test coverage

Links

Changelogs

Re-run a test

Before you merge

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Etheryte Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Etheryte left a comment

Choose a reason for hiding this comment

Uh oh!

cbbayburt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cbbayburt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbbayburt Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cbbayburt Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cbbayburt commented Nov 21, 2025

SSM tabs:

SSM index page shortcuts:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wweellddeerr commented Nov 5, 2025 •

edited

Loading