-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automatic formik form submission #129
base: dev
Are you sure you want to change the base?
Conversation
…k onChange function
WalkthroughWalkthroughThe changes introduce a new dependency, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (1)
src/forms/FormikAutoSubmit.stories.tsx (1)
1-35
: Replace alert with a more realistic action.Using
alert
in theonSubmit
handler is not ideal for real-world applications. Consider replacing it withconsole.log
or a more realistic action, such as an API call or state update.- alert(`Form submitted with value: ${values.name}`) + console.log(`Form submitted with value: ${values.name}`)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (3)
- package.json (1 hunks)
- src/forms/FormikAutoSubmit.stories.tsx (1 hunks)
- src/forms/FormikAutoSubmit.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
fixes old values in formik onChange function
issues:
jaredpalmer/formik#2106
jaredpalmer/formik#2083
future fix: jaredpalmer/formik#3947