docs: update examples to use end slot instead of inline styles#5323
Merged
web-padawan merged 3 commits intomainfrom Mar 5, 2026
Merged
docs: update examples to use end slot instead of inline styles#5323web-padawan merged 3 commits intomainfrom
web-padawan merged 3 commits intomainfrom
Conversation
web-padawan
commented
Mar 5, 2026
| Button delete = new Button("Delete"); | ||
| delete.setEnabled(false); | ||
| delete.addThemeVariants(ButtonVariant.ERROR); | ||
| delete.getStyle().set("margin-inline-start", "auto"); |
Member
Author
There was a problem hiding this comment.
This is no longer needed as we use footer.addToEnd(delete) below.
web-padawan
force-pushed
the
docs/button-grid-slots
branch
from
cdb62e8 to
909d845
Compare
web-padawan
changed the title
web-padawan
commented
Mar 5, 2026
| }} | ||
| > | ||
| <h4 style={{ margin: 0 }} id="notifications-heading"> | ||
| <h4 id="notifications-heading"> |
Member
Author
There was a problem hiding this comment.
It's not needed to reset margin as both Lumo and Aura do it for headings.
web-padawan
force-pushed
the
docs/button-grid-slots
branch
from
1787878 to
a391feb
Compare
DiegoCardoso
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use
slot="end"in HorizontalLayout to remove inline styles settingmargintoauto.