Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setters for all public vals that were previously vars #18409

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add setters for all public vals that were previously vars #18409

wants to merge 1 commit into from

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Jan 8, 2024

Fixes #18389

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Test Results

1 055 files  ± 0  1 055 suites  ±0   1h 15m 55s ⏱️ - 8m 15s
6 796 tests ± 0  6 751 ✅ ± 0  45 💤 ±0  0 ❌ ±0 
7 083 runs   - 24  7 027 ✅  - 24  56 💤 ±0  0 ❌ ±0 

Results for commit ec01812. ± Comparison against base commit 642ee5c.

@tepi tepi marked this pull request as draft January 9, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaits another ticket external dependency +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Essential configuration api's removed in VaadinFlowPluginExtension
2 participants
@tepi @vaadin-bot