Adds isApplied feature for Binding #18540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
requested changes
Jan 25, 2024
flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java
Outdated
Show resolved
Hide resolved
flow-data/src/test/java/com/vaadin/flow/data/binder/BinderTest.java
Outdated
Show resolved
Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java
Outdated
Show resolved
Hide resolved
|
knoobie
reviewed
Jan 25, 2024
| } | ||
| }; | ||
| return binding -> !(binding.getField() instanceof Component c) | ||
| || c.isVisible(); |
There was a problem hiding this comment.
nit: the previous version looked way more readable, this feels like brain training :D
mcollovati
previously approved these changes
Jan 26, 2024
tepi
force-pushed
the
feat/add-isapplied-for-binding
branch
from
85dd5f4 to
87adb88
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developer to ignore selected bindings via providing a predicate for a binding that is tested before validating the binding, or writing the binding value to bean. Default implementation ignores bindings for which the bound field is not visible.