fix: prevent duplicated history entry with vaadin-router #21305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using legacy vaadin-router, browser history for client side navigation is updated by the router itself when navigation completes. However, in some situations the history gets updated also by the server side, causing two history entries for the same navigation and consequently a wrong behavior if pressing browser back button. This change: - Prevents updating history on the server side, unless the server is handling a postponed navigation for which vaadin-router does not update the history - Adds a test module for vaadin-router with the most common navigation tests - Re-enables several tests that are now passing, likely because previous changes fixed the related issues Fixes #21243 Fixes #19494 Fixes vaadin/hilla#335
Test Results1 214 files + 22 1 214 suites +22 1h 20m 27s ⏱️ + 1m 24s Results for commit 2479d3e. ± Comparison against base commit 4a2e749. This pull request removes 2 and adds 38 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
caalador
previously approved these changes
Apr 22, 2025
flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java
Outdated
Show resolved
Hide resolved
caalador
approved these changes
Apr 22, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
When using legacy vaadin-router, browser history for client side navigation is updated by the router itself when navigation completes. However, in some situations the history gets updated also by the server side, causing two history entries for the same navigation and consequently a wrong behavior if pressing browser back button. This change: - Prevents updating history on the server side, unless the server is handling a postponed navigation for which vaadin-router does not update the history - Adds a test module for vaadin-router with the most common navigation tests - Re-enables several tests that are now passing, likely because previous changes fixed the related issues Fixes #21243 Fixes #19494 Fixes vaadin/hilla#335
vaadin-bot
added a commit
that referenced
this pull request
Apr 22, 2025
…: 24.7) (#21319) * fix: prevent duplicated history entry with vaadin-router (#21305) When using legacy vaadin-router, browser history for client side navigation is updated by the router itself when navigation completes. However, in some situations the history gets updated also by the server side, causing two history entries for the same navigation and consequently a wrong behavior if pressing browser back button. This change: - Prevents updating history on the server side, unless the server is handling a postponed navigation for which vaadin-router does not update the history - Adds a test module for vaadin-router with the most common navigation tests - Re-enables several tests that are now passing, likely because previous changes fixed the related issues Fixes #21243 Fixes #19494 Fixes vaadin/hilla#335 * Fix module parent pom version --------- Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using legacy vaadin-router, browser history for client-side navigation is updated by the router itself when navigation completes. However, in some situations the history gets updated also by the server side, causing two history entries for the same navigation and consequently a wrong behavior if pressing the browser back button.
This change:
Fixes #21243
Fixes #19494
Fixes vaadin/hilla#335