Tweaked layouttester tests to be more informative. (#11800)#11813
Merged
Ansku merged 5 commits intovaadin:masterfrom Mar 23, 2020
Merged
Tweaked layouttester tests to be more informative. (#11800)#11813Ansku merged 5 commits intovaadin:masterfrom
Ansku merged 5 commits intovaadin:masterfrom
Conversation
Ansku
force-pushed
the
update20191111testsV8
branch
from
1b1b0de to
29379e6
Compare
Contributor
|
Does this supercede #11688 ? |
Member
Author
What do you mean? It's a different set of tests. |
Ansku
force-pushed
the
update20191111testsV8
branch
2 times, most recently
from
7d682aa to
fc8a387
Compare
Ansku
force-pushed
the
update20191111testsV8
branch
from
fc8a387 to
faf0ee7
Compare
TatuLund
approved these changes
Mar 5, 2020
Contributor
TatuLund
left a comment
TatuLund
left a comment
There was a problem hiding this comment.
Reviewed 132 of 132 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
TatuLund
approved these changes
Mar 5, 2020
Contributor
TatuLund
left a comment
TatuLund
left a comment
There was a problem hiding this comment.
Reviewable status:
Ansku
added a commit
that referenced
this pull request
Mar 24, 2020
TatuLund
pushed a commit
that referenced
this pull request
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is