Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to React 19 rc #2565

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Upgrade to React 19 rc #2565

wants to merge 5 commits into from

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 24, 2024

No description provided.

@Artur- Artur- force-pushed the react19 branch 5 times, most recently from 821c00b to e6f4dea Compare June 25, 2024 10:29
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (5a060a9) to head (51ecf09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
+ Coverage   90.74%   90.83%   +0.09%     
==========================================
  Files          66       66              
  Lines        2646     2762     +116     
  Branches      526      526              
==========================================
+ Hits         2401     2509     +108     
- Misses         77       79       +2     
- Partials      168      174       +6     
Flag Coverage Δ
unittests 90.83% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Artur-
Copy link
Member Author

Artur- commented Jun 28, 2024

This cannot work until preact signals supports React 19 because the symbol name used for react elements has changed, see preactjs/signals#580 (comment)

@Artur- Artur- changed the title feat: Upgrade to React 19 feat: Upgrade to React 19 rc Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant