feat: plugin file as system property #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinVaadin
requested changes
Oct 31, 2024
src/main/kotlin/com/vaadin/plugin/hotswapagent/HotswapAgentProgramPatcher.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/vaadin/plugin/copilot/DefaultProgramPatcher.kt
Outdated
Show resolved
Hide resolved
…gin-file-as-system-property
|
Remember to align property name with https://github.com/vaadin/copilot-internal/pull/3631 |
MarcinVaadin
reviewed
Nov 4, 2024
src/main/kotlin/com/vaadin/plugin/copilot/DefaultProgramPatcher.kt
Outdated
Show resolved
Hide resolved
MarcinVaadin
reviewed
Nov 4, 2024
MarcinVaadin
reviewed
Nov 4, 2024
MarcinVaadin
approved these changes
Nov 5, 2024
|
Artifact build on last commit: distributions.zip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #141
fixes #137 with client part
With this PR the client is not anymore responsible to lookup for the plugin file. If the plugin has already detected or created the file it will pass the location through a system property.