fix: detect Vaadin based on pom and gradle #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
reviewed
Apr 12, 2024
Artur-
reviewed
Apr 12, 2024
Artur-
reviewed
Apr 12, 2024
MarcinVaadin
force-pushed
the
fix/check-com-vaadin-in-pom-and-gradle
branch
from
f54af4c
to
d1f7b19
Compare
abdullahtellioglu
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed module manager library scanning to simpler pom and gradle files search.
Can be tested using:
intellij-plugin-1.0-SNAPSHOT.zip
Test scenario:
Create new Vaadin application using
npx @hilla/cli init --pre tGo to directory
cd tOpen idea from terminal using
idea .or/Applications/IntelliJ\ IDEA.app/Contents/MacOS/idea .Plugin should be automatically started
Fixes #29