Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: open editor after file has been saved #42

Merged
merged 1 commit into from
May 29, 2024

Conversation

MarcinVaadin
Copy link
Member

Description

Open editor when saving file contents

Fixes https://github.com/vaadin/copilot-internal/issues/1817

@MarcinVaadin MarcinVaadin changed the title open editor after file hsa been saved chore: open editor after file has been saved May 29, 2024
Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin MarcinVaadin requested review from emarc and mgarciavaadin and removed request for emarc May 29, 2024 07:58
Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Tested through building the plugin and debugging, IT works!
Not working installing the plugin with downloaded zip file but I guess it is a problem at my end.

@MarcinVaadin MarcinVaadin merged commit ed0d2ec into main May 29, 2024
3 checks passed
@MarcinVaadin MarcinVaadin deleted the chore/open-editor-for-updated-file branch May 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants