test: Add react mixed test module #6865

caalador · 2024-10-11T11:11:47Z

Add a mixed React Hilla Flow
test module to test interoperability
of the 2 features

Fixes #4972

Add a mixed React Hilla Flow test module to test interoperability of the 2 features Fixes #4972

github-actions · 2024-10-11T12:03:06Z

Dependencies Report

🚫 Vulnerabilities:
- Vulnerabilities in: pkg:maven/org.springframework/[email protected] [CVE-2024-38820] (osv-scan)
  ·
- Vulnerabilities in: pkg:maven/org.springframework/[email protected] [CVE-2024-38820] (owasp)
  · cpe:2.3:a:vmware:spring_framework::::::::
- Vulnerabilities in: pkg:maven/org.springframework/[email protected] [CVE-2024-38820] (owasp)
  · cpe:2.3:a:vmware:spring_framework::::::::
- Vulnerabilities in: pkg:maven/org.springframework/[email protected] [CVE-2024-38819, CVE-2024-38820] (owasp)
  · cpe:2.3:a:org.springframework:spring-webmvc:6.1.13:::::::*
  · cpe:2.3:a:vmware:spring_framework::::::::
- Vulnerabilities in: pkg:maven/org.springframework/[email protected] [CVE-2024-38820] (owasp)
  · cpe:2.3:a:vmware:spring_framework::::::::
🟠 Known Vulnerabilities:
- Vulnerabilities in: pkg:npm/[email protected] [CVE-2024-34394, CVE-2024-34393] (osv-scan)
  👌 This is coming from the tools, @cyclonedx/cyclonedx, we have used for sbom module, FP for us.
  ·
- Vulnerabilities in: pkg:maven/com.fasterxml.jackson.core/[email protected] [CVE-2023-35116] (owasp)
  👌 Not a valid CVE report based on the vendor analysis and research
  · cpe:2.3:a:fasterxml:jackson-databind::::::::
- Vulnerabilities in: pkg:maven/me.friwi/jcef-api@jcef-af53d63%2Bcef-104.4.23%2Bg46ae630%2Bchromium-104.0.5112.102 [CVE-2024-21639, CVE-2024-21640] (owasp)
  👌 Wait for the update from the jcefmaven community. Meanwhile the swing-kit is supposed to be used with fixed websites and not to browse the internet, we have a check for that, so the only possible attacker would be the same person that created the swing application, aka our customer devs. so this vulnerability is not classified by us as critical issue
  · cpe:2.3:a:chromiumembedded:chromium_embedded_framework::::::::
📔 No License Issues
🟠 Changes in 24.6-SNAPSHOT since V24.6.0.alpha1
- 1 packages modified (1 external, 0 vaadin)
- 1059 packages same (834 external, 225 vaadin)

[Click for more Details]

vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/components.tsx

mshabarov

I couldn't find the following test cases:

Navigation lifecycle events handling on server: that event is triggered with expected number of times
Server-side API for browser navigation: History::back/forward, History::pushState/replaceState

Do you think this isn't needed?

mshabarov · 2024-10-23T10:58:29Z

vaadin-platform-react-hybrid-test/src/main/frontend/utils/css-utils.ts

+/**
+ * Utility function for importing style modules. This is a temporary
+ * solution until there is a standard solution available
+ * @see https://github.com/vaadin/vaadin-themable-mixin/issues/73


This issues seems resolved, maybe this file is not needed?

Probably can be removed. I just started with a full copy of the original hybrid module.

mshabarov · 2024-10-23T11:21:10Z

...tform-react-hybrid-test/src/main/java/com/vaadin/platform/react/test/views/FlowMainView.java

+import com.vaadin.flow.router.RouterLink;
+
+@Route("flow")
+public class FlowMainView extends VerticalLayout {


I don't know why this doesn't happen in the validation of this PR, but locally I get

Caused by: com.vaadin.flow.server.InvalidRouteConfigurationException: Invalid route configuration. The following Hilla route(s) conflict with configured Flow routes: flow

because this view has apparently the same mapping as views/flow/@index.tsx.

Even if I remove views/flow/@index.tsx, it still throws, because apparently it sees an entry with "flow" path in the file-routes.json.

I fixed it by using "flow-flow" mapping for Flow view.

There was the check for duplicate routes PR just a while ago and this one is older than that.
But just removing the @index.tsx from the flow folder should be enough. Probably the mapping check needs some change on this.

Just removing it doesn't help. Perhaps we have a bug in conflicts detection in Flow.

Ok, validation passes.

caalador · 2024-10-24T09:22:13Z

I'm not certain it is run as it is behind the profile. Same as the other hybrid which I don't know where it is executed.

        <profile>
            <id>react-hybrid</id>
            <modules>
                <module>vaadin-platform-react-hybrid-test</module>
            </modules>
        </profile>

@ZheSun88 any idea on the execution?

mshabarov · 2024-10-24T09:23:45Z

At least yesterday I saw that these IT tests were running according to the log.

mshabarov · 2024-10-24T09:27:09Z

pom.xml

@@ -76,6 +76,7 @@
                <module>vaadin-dev-bundle</module>
                <module>vaadin-prod-bundle/pom-unoptimized.xml</module>
                <module>vaadin-prod-bundle</module>
+                <module>vaadin-platform-react-hybrid-test</module>


The test module is behind a profile and added in the standard list of modules, maybe we should excluded it from here and leave it only behind a profile?

mshabarov · 2024-10-24T11:32:24Z

@ZheSun88 could you please add this profile to CI when appropriate?

caalador and others added 3 commits October 11, 2024 14:10

feat: Add react mixed test module

cbd7325

Add a mixed React Hilla Flow test module to test interoperability of the 2 features Fixes #4972

Merge branch 'main' into issues/4972-flow-hilla-react-module

b085182

update to new 24.6

90421e2

caalador added 6 commits October 11, 2024 15:06

react in name and description

5c928bd

fix application configuration packages.

209004f

Use abstractPlatformTest for test base

689fd64

Remove log, fix test

535c1c7

Flow to hilla navigation.

9604ac6

fix menu find

f322b92

caalador force-pushed the issues/4972-flow-hilla-react-module branch from 08e058a to f322b92 Compare October 14, 2024 09:55

caalador and others added 3 commits October 14, 2024 14:18

Add some navigation tests.

8701499

Update with navigation tests.

f7a8879

Merge branch 'main' into issues/4972-flow-hilla-react-module

dc41eca

caalador marked this pull request as ready for review October 15, 2024 07:46

remove name fusion and add react instead

6f5d7ea

ZheSun88 requested a review from mshabarov October 16, 2024 09:52

ZheSun88 reviewed Oct 17, 2024

View reviewed changes

vaadin-platform-react-hybrid-test/src/main/frontend/views/hilla/components.tsx Show resolved Hide resolved

caalador and others added 2 commits October 17, 2024 13:57

Add Dashboard component

87cb181

Merge branch 'main' into issues/4972-flow-hilla-react-module

68faed0

mshabarov reviewed Oct 23, 2024

View reviewed changes

mshabarov changed the title ~~feat: Add react mixed test module~~ test: Add react mixed test module Oct 23, 2024

remove index to not get issues with flow route ´flow´

e6bf7df

mshabarov approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'main' into issues/4972-flow-hilla-react-module

6bb1874

mshabarov reviewed Oct 24, 2024

View reviewed changes

module only behind profile

fc4d8e2

mshabarov approved these changes Oct 24, 2024

View reviewed changes

mshabarov merged commit a61392e into main Oct 24, 2024
2 of 3 checks passed

mshabarov deleted the issues/4972-flow-hilla-react-module branch October 24, 2024 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add react mixed test module #6865

test: Add react mixed test module #6865

caalador commented Oct 11, 2024

github-actions bot commented Oct 11, 2024 •

edited

Loading

mshabarov left a comment •

edited

Loading

mshabarov Oct 23, 2024

caalador Oct 23, 2024

mshabarov Oct 23, 2024 •

edited

Loading

mshabarov Oct 23, 2024

mshabarov Oct 23, 2024

caalador Oct 23, 2024

mshabarov Oct 23, 2024

mshabarov Oct 24, 2024

caalador commented Oct 24, 2024

mshabarov commented Oct 24, 2024

mshabarov Oct 24, 2024

caalador Oct 24, 2024

mshabarov commented Oct 24, 2024

test: Add react mixed test module #6865

test: Add react mixed test module #6865

Conversation

caalador commented Oct 11, 2024

github-actions bot commented Oct 11, 2024 • edited Loading

Dependencies Report

mshabarov left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshabarov Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caalador commented Oct 24, 2024

mshabarov commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshabarov commented Oct 24, 2024

github-actions bot commented Oct 11, 2024 •

edited

Loading

mshabarov left a comment •

edited

Loading

mshabarov Oct 23, 2024 •

edited

Loading