Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade type-fest to 4.30.1 #288

Merged
merged 1 commit into from
Dec 25, 2024
Merged

chore: downgrade type-fest to 4.30.1 #288

merged 1 commit into from
Dec 25, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 25, 2024 •
edited
Loading

Description

The type-fest was upgraded to 4.30.2 in #279. However, this version causes TypeScript errors when running npm run validate:types due to sindresorhus/type-fest#1013:

scripts/generator.ts:124:88 - error TS2345: Argument of type 'GenericJsContributions' is not assignable to parameter of type 'string'.
  Type 'number' is not assignable to type 'string'.

This PR temporarily downgrades type-fest to 4.30.1, which doesn't have this issue.

Type of change

  • Internal

@vursen vursen requested a review from Artur- December 25, 2024 09:08
@vursen vursen mentioned this pull request Dec 25, 2024
Merged
1 task
@vursen vursen merged commit 671c174 into main Dec 25, 2024
2 checks passed
@vursen vursen deleted the downgrade-type-fest-dep branch December 25, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artur- Artur- Artur- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @Artur-