revert login-form changes

vaadin · Nov 6, 2024 · 1f3c000 · 1f3c000
1 parent 36550d2
commit 1f3c000
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/packages/login/src/vaadin-lit-login-form.js b/packages/login/src/vaadin-lit-login-form.js
@@ -59,7 +59,6 @@ class LoginForm extends LoginFormMixin(ElementMixin(ThemableMixin(PolylitMixin(L
             .errorMessage="${this.i18n.errorMessage.username}"
             id="vaadinLoginUsername"
             required
-            manual-validation
             @keydown="${this._handleInputKeydown}"
             autocapitalize="none"
             autocorrect="off"
@@ -75,7 +74,6 @@ class LoginForm extends LoginFormMixin(ElementMixin(ThemableMixin(PolylitMixin(L
             .errorMessage="${this.i18n.errorMessage.password}"
             id="vaadinLoginPassword"
             required
-            manual-validation
             @keydown="${this._handleInputKeydown}"
             spellcheck="false"
             autocomplete="current-password"

diff --git a/packages/login/src/vaadin-login-form-mixin.js b/packages/login/src/vaadin-login-form-mixin.js
@@ -50,10 +50,7 @@ export const LoginFormMixin = (superClass) =>
       const userName = this.$.vaadinLoginUsername;
       const password = this.$.vaadinLoginPassword;
 
-      userName.validate();
-      password.validate();
-
-      if (this.disabled || userName.invalid || password.invalid) {
+      if (this.disabled || !(userName.validate() && password.validate())) {
         return;
       }
 

diff --git a/packages/login/src/vaadin-login-form.js b/packages/login/src/vaadin-login-form.js
@@ -70,7 +70,6 @@ class LoginForm extends LoginFormMixin(ElementMixin(ThemableMixin(PolymerElement
             error-message="[[i18n.errorMessage.username]]"
             id="vaadinLoginUsername"
             required
-            manual-validation
             on-keydown="_handleInputKeydown"
             autocapitalize="none"
             autocorrect="off"
@@ -86,7 +85,6 @@ class LoginForm extends LoginFormMixin(ElementMixin(ThemableMixin(PolymerElement
             error-message="[[i18n.errorMessage.password]]"
             id="vaadinLoginPassword"
             required
-            manual-validation
             on-keydown="_handleInputKeydown"
             spellcheck="false"
             autocomplete="current-password"