Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dashboard dense mode #7881

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Sep 27, 2024

Description

This PR adds dense mode support to dashboard and dashboard layout.

Fixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=81315994

Part of vaadin/platform#6626

Type of change

Feature

@ugur-vaadin ugur-vaadin marked this pull request as ready for review September 27, 2024 12:25
@tomivirkki tomivirkki changed the title feat: add dense mode feat: add dashboard dense mode Sep 30, 2024
@@ -10,11 +10,12 @@
*/
import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
import { DashboardLayoutMixin } from './vaadin-dashboard-layout-mixin';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing .js suffix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

sonarcloud bot commented Sep 30, 2024

@ugur-vaadin ugur-vaadin merged commit c801860 into feat/dashboard Sep 30, 2024
9 checks passed
@ugur-vaadin ugur-vaadin deleted the feat/dashboard-dense branch September 30, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants