Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: do not validate login form fields on blur #8101

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Nov 7, 2024

Description

Enables manual validation mode for the login form fields to prevent their validation on blur. This validation is problematic because it triggers an error message that shifts down the content below the field. As a result, if the blur event was caused by a click on an element positioned below the field, that element will miss the click event.

Fixes vaadin/flow-components#6667

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Nov 7, 2024

@vursen vursen merged commit b9c6590 into main Nov 7, 2024
9 checks passed
@vursen vursen deleted the fix/login-form/delay-validation-until-submit branch November 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login form regression cause components outside of it to require two clicks to work
2 participants