Skip to content

experiment: Dialog base styles #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

experiment: Dialog base styles #9438

wants to merge 1 commit into from

Conversation

jouni
Copy link
Member

@jouni jouni commented Jun 9, 2025

Screenshot 2025-06-09 at 13 31 15

@jouni jouni force-pushed the experiment/base-dialog branch from e1baa6f to 1ab2729 Compare June 9, 2025 10:56
@web-padawan web-padawan force-pushed the experiment/base-dialog branch from 1ab2729 to 654b885 Compare June 10, 2025 14:49
web-padawan
web-padawan reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and force-pushed to work after some core styles refactoring on main branch.

web-padawan
web-padawan reviewed Jun 10, 2025
View reviewed changes
@web-padawan web-padawan force-pushed the experiment/base-dialog branch from 654b885 to 6e7938b Compare June 10, 2025 14:55
@web-padawan web-padawan force-pushed the experiment/base-dialog branch from 6e7938b to 42784d0 Compare June 10, 2025 14:58
@web-padawan
Copy link
Member

For some reason in the dev page the overlay collapses when toggling setting width: 280px (works fine with 300px):

Screenshot 2025-06-10 at 16 57 05

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jouni @web-padawan