Add Python 3.14 (beta) to CI/CD #2650
Conversation
|
Warning Rate limit exceeded@arkid15r has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughPython 3.14 support was added to both the CI/CD workflow and tox configuration. The test matrix in the workflow and the tox environment list now include Python 3.14, expanding the range of Python versions tested. No other changes were made. Changes
Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2650 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 263 263
Lines 15696 15696
Branches 2117 2117
=========================================
Hits 15696 15696 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-cd.yml(1 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (2)
- GitHub Check: Test Python 3.14 on windows-latest
- GitHub Check: Test Python 3.14 on ubuntu-latest
🔇 Additional comments (1)
.github/workflows/ci-cd.yml (1)
87-87: Approve Python 3.14 in the CI matrix
Including'3.14'here ensures tests run on the upcoming Python release across all supported OSes. The existingallow-prereleases: truesetting covers the beta channel.
| @@ -4,7 +4,7 @@ requires = | |||
| env_list = | |||
| docs | |||
| pre-commit | |||
| python3.{13, 12, 11, 10, 9} | |||
| python3.{14, 13, 12, 11, 10, 9} | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Approve Python 3.14 addition and refine env_list formatting
The addition of python3.14 aligns tox with the CI matrix, and skip_missing_interpreters = true handles missing interpreters gracefully. For cleaner brace expansion, consider removing spaces:
- python3.{14, 13, 12, 11, 10, 9}
+ python3.{14,13,12,11,10,9}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| python3.{14, 13, 12, 11, 10, 9} | |
| python3.{14,13,12,11,10,9} |
🤖 Prompt for AI Agents
In tox.ini at line 7, the python versions list uses brace expansion with spaces,
which is not standard and may cause issues. Remove the spaces inside the braces
so it reads python3.{14,13,12,11,10,9} without spaces. This aligns tox with the
CI matrix and ensures proper environment creation.
|
I've already tried adding 3.14, but numpy doesn't have wheels for Windows yet, and the built version doesn't work. 🤷♂️ |
I see, so retrying is useless here... So what's the plan here -- just wait until it's supported? I guess I'll convert it to draft until then... |
(from numpy/numpy#29062) |
|
Proposed change
Add Python 3.14 (beta) to CI/CD. Final release expected on 2025-10-07.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green