feat: wrap picotls backend #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
picotls
branch
from
ee4795e to
bf6aae8
Compare
richard-ramos
force-pushed
the
picotls
branch
from
bf6aae8 to
81e03bd
Compare
|
Ah interesting! this seems to not work on windows and macos/arm64. Will investigate |
richard-ramos
force-pushed
the
picotls
branch
from
32ee315 to
eb5895c
Compare
richard-ramos
force-pushed
the
picotls
branch
3 times, most recently
from
979cade to
50f2bcc
Compare
richard-ramos
force-pushed
the
picotls
branch
from
2936843 to
307755b
Compare
richard-ramos
force-pushed
the
picotls
branch
3 times, most recently
from
eaff2e2 to
f21ed34
Compare
richard-ramos
force-pushed
the
picotls
branch
3 times, most recently
from
97b533a to
97be291
Compare
|
This is ready for review. |
* feat: load certificates from memory * feat: load private key from memory * fix: load key
richard-ramos
force-pushed
the
picotls
branch
from
97be291 to
44a9151
Compare
vladopajic
reviewed
Feb 24, 2025
richard-ramos
force-pushed
the
picotls
branch
5 times, most recently
from
7f84462 to
7d870d9
Compare
richard-ramos
force-pushed
the
picotls
branch
from
7d870d9 to
7cede58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in issue #961 on the nim-libp2p repository, at the time of writing this pull request, mbedTLS does not yet export the necessary APIs required for the QUIC protocol. Similarly, BearSSL has not implemented support for TLS 1.3. To overcome this limitation and unblock the implementation of QUIC support for nim-libp2p, I decided to wrap one of the TLS backends supported by ngtcp2: picotls.
Currently, ngtcp2 supports the following TLS backends:
After reviewing the available options, the most promising choices appeared to be picotls or quictls. Both seem to provide lightweight and efficient TLS stacks specifically designed for QUIC. I ended up choosing picotls but ultimately, it is during the integration of this library with nim-quic that the final decision might change depending on issues that might be encountered.