Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status old RFCs - moving to RFC Index #109

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

Cofson
Copy link

@Cofson Cofson commented Nov 4, 2024

No description provided.

@Cofson Cofson requested a review from jimstir November 4, 2024 06:22
Copy link
Collaborator

@jimstir jimstir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments that should be fixed. All specs should be in deprecated and placed in a status deprecated folder. (e.g.status/deprecated/1/client.md) Also the .obsidian subfolder should be removed. And there are some links in status specs in this repo that link to specs.status, they should be updated.

Comment on lines +28 to +52
## Table of Contents

- Abstract
- Table of Contents
- Introduction
- Protocol layers
- Protobuf
- Components
- P2P Overlay
- Node discovery and roles
- Bootstrapping
- Discovery
- Mobile nodes
- Transport privacy and Whisper/Waku usage
- Secure Transport
- Data Sync
- Payloads and clients
- BIPs and EIPs Standards support
- Security Considerations
- Design Rationale
- P2P Overlay
- Why devp2p? Why not use libp2p?
- What about other RLPx subprotocols like LES and Swarm?
- Why do you use Whisper?
- Why do you use Waku?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table of contents and the list can be removed for all the specs.

Comment on lines +2 to +5
slug: 1
title: 1/CLIENT
name: Client
status: draft
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the slug and the number in front of the title for all the specs.


A Mobile node is a Whisper and/or Waku node connecting to the network.
Mobile nodes **MAY** relay messages.
See 3/WHISPER-USAGE and 10/WAKU-USAGE for more details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the slugs for references in each spec.

Status nodes rely on these Infura nodes
to validate transaction integrity and report consistent history.

[Key handling is described here](https://specs.status.im/spec/2-account.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update links for specs being moved to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants