Make manual failover reset the on-going election to promote failover #1274
+65
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a manual failover got timed out, like the election don't get the enough votes, since we have a auth_timeout and a auth_retry_time, a new manual failover will not be able to proceed on the replica side. Like if we initiate a new manual failover after a election timed out, we will pause the primary, but on the replica side, due to retry_time, replica does not trigger the new election and the manual failover will eventually time out. In this case, if we initiate manual failover again and there is an ongoing election, we will reset it so that the replica can initiate a new election at the manual failover's request. Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
added
the
run-extra-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1274 +/- ##
============================================
+ Coverage 70.69% 70.70% +0.01%
============================================
Files 114 115 +1
Lines 63161 63160 -1
============================================
+ Hits 44650 44656 +6
+ Misses 18511 18504 -7
|
|
A log demo from the test case (before the fix). replica: the primary: |
hpatro
reviewed
Nov 8, 2024
Comment on lines
-4850
to
+4869
| server.cluster->mf_can_start = 1; | ||
| manualFailoverCanStart(); |
There was a problem hiding this comment.
Should we rather invoke resetManualFailover and clean up failover_auth_time in that period?
We should anyway cleanup failover_auth_time in the resetManualFailover method.
There was a problem hiding this comment.
I have thought about putting it in resetManualFailover, but I was worried about introducing other problems since resetManualFailover is called in many places.
…_reset Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
commented
Nov 11, 2024
| R 3 cluster failover | ||
|
|
||
| # Waiting for primary and replica to confirm manual failover timeout. | ||
| wait_for_log_messages 0 {"*Manual failover timed out*"} 0 1000 50 |
There was a problem hiding this comment.
i forgot to mention in here, the wait will take at least 5 seconds since the manual failover timeout is 5s, i can use other fields maybe like epoch to replace it if needed.
There was a problem hiding this comment.
Using log messages should be OK.
madolson
approved these changes
Nov 14, 2024
| R 3 cluster failover | ||
|
|
||
| # Waiting for primary and replica to confirm manual failover timeout. | ||
| wait_for_log_messages 0 {"*Manual failover timed out*"} 0 1000 50 |
There was a problem hiding this comment.
Using log messages should be OK.
Comment on lines
+207
to
+208
| R 1 debug drop-cluster-packet-filter $CLUSTER_PACKET_TYPE_NONE | ||
| R 2 debug drop-cluster-packet-filter $CLUSTER_PACKET_TYPE_NONE |
There was a problem hiding this comment.
I really like the usage of these constants, we should probably do it more to improve readability in tests.
Signed-off-by: Binbin <[email protected]>
zuiderkwast
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a manual failover got timed out, like the election don't get the
enough votes, since we have a auth_timeout and a auth_retry_time, a
new manual failover will not be able to proceed on the replica side.
Like if we initiate a new manual failover after a election timed out,
we will pause the primary, but on the replica side, due to retry_time,
replica does not trigger the new election and the manual failover will
eventually time out.
In this case, if we initiate manual failover again and there is an
ongoing election, we will reset it so that the replica can initiate
a new election at the manual failover's request.