Add zmalloc PREFIX_SIZE to fix sds alloc size test #1314
+25
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently sdsAllocSize does not calculate PREFIX_SIZE when no malloc_size available, this casue test_typesAndAllocSize fail in the new unittest. Signed-off-by: Binbin <[email protected]>
|
I guess we don't want to modify sdsAllocSize to include it? so i just modify the test. The failure test CI: https://github.com/valkey-io/valkey/actions/runs/11865335400/job/33070348096#step:7:254 |
Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1314 +/- ##
============================================
- Coverage 70.73% 70.70% -0.03%
============================================
Files 115 115
Lines 63158 63158
============================================
- Hits 44674 44657 -17
- Misses 18484 18501 +17
|
madolson
approved these changes
Nov 18, 2024
Comment on lines
+255
to
+258
| size_t sdsRealAllocSize(sds s) { | ||
| return sdsAllocSize(s) + PREFIX_SIZE; | ||
| } | ||
|
|
There was a problem hiding this comment.
From a modularization perspective, we could add this as a function in zmalloc.c and forward declare it here to access it for tests but not expose it in the header file. I don't know if I prefer that approach though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sdsAllocSize does not calculate PREFIX_SIZE when no
malloc_size available, this casue test_typesAndAllocSize fail
in the new unittest.