Sendable fixes and other cleanup #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lves a lot of marking things Sendable, or marking things nonisolated(unsafe) in conjunction with a lock. LeafTag.defaultTags remains a distinct problem. Also got rid of the use of NonBlockingFileIO in NIOLeafFiles. Renamed Exports.swift -> Character+Identities.swift.
… of the time than, and at best only equivalent to, just doing .replacing(_:with:) (in 6.0+) or .replacingOccurrences(of:with:) (in 5.10).
…f paths and dates (tests no longer fail for users in DST-active timezones)
…en running anything other than Darwin or a Glibc Linux (i.e. especially not Android)
|
The failure of the integration tests is spurious; the |
ptoffy
approved these changes
Apr 1, 2025
…Core, alphabetize)
… exclude instead of resources to silence SwiftPM about the test templates, use the NIO singletons in tests
0xTim
approved these changes
Apr 1, 2025
…ascades from it. It is not used and was cluttering up the code to no purpose. Also cleaned up LeafDataStorage a lot in general and removed a chunk of other unused code on it and LeafData.
…f String to Error, we are not stuck with setting the bad example of actually using that conformance. Remove all such instances, using LeafError(.unknownError()) instead.
…l-only testing support methods we don't need (there is no public interface to directly specify an unsearchable source, not sure why sources even have that feature), exclude all performance tests on Android (they break there), get rid of a few unnecessary force-unwraps, get rid of the last usages of .trimmingCharacters(in:)
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.13.0
The big changes in this PR are making the code
Sendable-clean and minimally strict Concurrency-correct (emphasis on "minimally", there's still a bunch of stuff with futures going on). Accordingly with the release of Swift 6.1, the package also now requires a minimum version of Swift 5.10.Additional changes:
EventLoopFuture.wait().