Ability to filter by 4k/non-4k only #11
Conversation
|
Hi, I unfortunately missed your last message on the issue and now the page is 404 for me, is there any further input I could help you with? Thanks for adding this feature! |
|
@LaurenceBarnes Hey I disabled github issues as I don't have time to work on this for now (aside from fixing critical bugs). I'll finish my other projects and then start the rewrite for this. In my last reply I was just asking for clarification but don't remember what exactly. I tested the changes and it looks fine on my end. Do you have any issues with it? |
|
@varthe ah okay, thanks for the clarification, I was a little confused about it but it makes total sense. Redirecterr works perfectly fine overall, so that's great. If I found critical issues, how would I reach out to you? Regarding the issue itself, my additional observations where I encountered a problem/bug were a separate issue, so I would've closed that issue myself anyways. The differentiation between 4k and non4k instances works flawlessly once I figured out the config, thanks so much for that addition! The problems that I encountered and mentioned were about the users' permissions when they request. Currently, Redirecterr does cause an error in Jellyseerr if it tries to redirect requests from a user that has advanced request permissions (allowed to change folder and quality profile) even if that user does not change those settings. The workaround: Only request as users with default request permissions, which is feasible. That would be an entirely separate issue that I'd raise once you got time to work on it again. |
You can leave a message on one of the PRs like you did. Not sure if Github has a DM function
Ah yes I remember now. I was going to ask why you needed users with advanced permissions, since redirecterr is supposed to remove that need. Regardless It would require a complete rewrite anyway so it will wait until then. |
|
sure, will leave a message on a PR if necessary, unfortunately, there is no DM function on Github, but that will suffice.
that is true, the use case I had was essentially selecting a different quality profile (remux instead of normal Bluray/WEB) for a specific request. Naturally, there is no real criteria for redirecterr or jellyseerr to automatically determine whether I prefer something on that setting, unless I'd want every scifi movie in remux or something similar. In the meantime, the most efficient workaround for this would either be manually adjusting in sonarr/radarr after the request, or creating a user for remux requests and setup redirecterr to use that user as the criteria. Either way, since this requires a rewrite and has feasible workarounds, this is not that important - I simply noticed it during testing and was a little confused since at first I thought there really was a bug with the 4k/non4k filter. Luckily, it is not 😄 |
#9