Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xenorchestra_bonded_network resource #253

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

ddelnano
Copy link
Collaborator

@ddelnano ddelnano commented Aug 21, 2023

This adds the bonded form of the existing xenorchestra_network resource and completes #253. I initially tried to implement this as a single resource that could handle both the bonded and non bonded options, but ran into complications in the implementation. It would have been possible, but this ended up being much cleaner with this approach.

Testing

  • New tests pass
  • Follow up on VLAN support with bonded networks. The XCP-ng docs claim this is possible, but it doesn't appear to be easily done with the existing APIs (network.createBonded doesn't support a vlan argument). This is accomplished by providing a bonded PIF as an input to the network.create RPC call. This means terraform would model this by having the xenorchestra_network and xenorchestra_bonded_network working in conjunction with each other.
  • Add example showing basic usage (simple bonded network) and VLAN bonded network

@ddelnano ddelnano marked this pull request as ready for review August 21, 2023 04:35
@ddelnano ddelnano merged commit bb40c5d into master Sep 27, 2023
3 checks passed
@ddelnano ddelnano deleted the ddelnano/add-bonded-network-resource branch September 27, 2023 00:20
@ddelnano ddelnano added the enhancement New feature or request label Oct 10, 2023
@ddelnano ddelnano mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant