Add xenorchestra_bonded_network
resource
#253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bonded form of the existing
xenorchestra_network
resource and completes #253. I initially tried to implement this as a single resource that could handle both the bonded and non bonded options, but ran into complications in the implementation. It would have been possible, but this ended up being much cleaner with this approach.Testing
Follow up on VLAN support with bonded networks. The XCP-ng docs claim this is possible, but it doesn't appear to be easily done with the existing APIs (This is accomplished by providing a bonded PIF as an input to thenetwork.createBonded
doesn't support avlan
argument).network.create
RPC call. This means terraform would model this by having thexenorchestra_network
andxenorchestra_bonded_network
working in conjunction with each other.