Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use previous terraform releases for V0 to V1 state migration test #317

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Use previous terraform releases for V0 to V1 state migration test #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc544bc
Use previous terraform releases for V0 to V1 state migration test.
ddelnano Mar 13, 2024
8104b97
Remove Call from XoClient interface
ddelnano Mar 18, 2024
7d4e2ae
Clean up tf template functions
ddelnano Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions client/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,19 @@ func FindOrCreateVmForTests(vm *Vm, poolId, srId, templateName, tag string) {
*vm = *vmRes
}

func checkBlockDestroyOperation(vm *Vm) bool {
fmt.Printf("Found VM with blocked_operations=%v", vm.BlockedOperations)

for k, _ := range vm.BlockedOperations {

if k == "destroy" {
return true
}

}
return false
}

func RemoveVmsWithNamePrefix(prefix string) func(string) error {
return func(_ string) error {
fmt.Println("[DEBUG] Running vm sweeper")
Expand All @@ -748,6 +761,22 @@ func RemoveVmsWithNamePrefix(prefix string) func(string) error {
}
for _, vm := range vmsMap {
if strings.HasPrefix(vm.NameLabel, prefix) {
if checkBlockDestroyOperation(&vm) {
var success bool
blockedOperations := map[string]interface{}{
"destroy": nil,
}
params := map[string]interface{}{
"id": vm.Id,
"blockedOperations": blockedOperations,
}
client, _ := c.(*Client)
err := client.Call("vm.set", params, &success)

if err != nil {
log.Printf("error removing destroy block on vm `%s` during sweep: %s", vm.NameLabel, err)
}
}
fmt.Printf("[DEBUG] Deleting vm `%s`\n", vm.NameLabel)
err := c.DeleteVm(vm.Id)
if err != nil {
Expand Down
85 changes: 74 additions & 11 deletions xoa/resource_xenorchestra_vm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/ddelnano/terraform-provider-xenorchestra/client"
"github.com/ddelnano/terraform-provider-xenorchestra/xoa/internal"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
)

Expand Down Expand Up @@ -1729,14 +1728,29 @@ func TestAccXenorchestraVm_createWithV0StateMigration(t *testing.T) {
PreCheck: func() { testAccPreCheck(t) },
CheckDestroy: testAccCheckXenorchestraVmDestroy,
Steps: []resource.TestStep{
// TODO(ddelnano): Remove this once blocked_operations can work on create
{
ExternalProviders: map[string]resource.ExternalProvider{
"xenorchestra": {
Source: "terra-farm/xenorchestra",
VersionConstraint: "0.24.2",
},
},
Config: testAccVmConfig(vmName),
Config: testAccVmConfigWithWaitForIp(vmName, "false"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
resource.TestCheckNoResourceAttr(resourceName, "destroy_cloud_config_vdi_after_boot"),
),
},
{
ExternalProviders: map[string]resource.ExternalProvider{
"xenorchestra": {
Source: "terra-farm/xenorchestra",
VersionConstraint: "0.24.2",
},
},
Config: testAccVmConfigWithDeletionBlocked(vmName, "false"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
Expand All @@ -1750,7 +1764,7 @@ func TestAccXenorchestraVm_createWithV0StateMigration(t *testing.T) {
VersionConstraint: "0.25.0",
},
},
Config: testAccVmConfigWithWaitForIp(vmName, "true"),
Config: testAccVmConfigWithDeletionBlocked(vmName, "true"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
Expand All @@ -1759,26 +1773,29 @@ func TestAccXenorchestraVm_createWithV0StateMigration(t *testing.T) {
PlanOnly: true,
ExpectNonEmptyPlan: true,
},
// This step should fail if the state upgrade does not happen
{
ProviderFactories: map[string]func() (*schema.Provider, error){
"xenorchestra": func() (*schema.Provider, error) {
return testAccFailToDeleteVmProvider, nil
ExternalProviders: map[string]resource.ExternalProvider{
"xenorchestra": {
Source: "terra-farm/xenorchestra",
VersionConstraint: "0.25.1",
},
},
Config: testAccVmConfigWithWaitForIp(vmName, "true"),
Config: testAccVmConfigWithDeletionBlocked(vmName, "true"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
resource.TestCheckResourceAttr(resourceName, "destroy_cloud_config_vdi_after_boot", "false"),
),
},
{
ProviderFactories: map[string]func() (*schema.Provider, error){
"xenorchestra": func() (*schema.Provider, error) {
return Provider(), nil
ExternalProviders: map[string]resource.ExternalProvider{
"xenorchestra": {
Source: "terra-farm/xenorchestra",
VersionConstraint: "0.25.1",
},
},
Config: testAccVmConfigWithWaitForIp(vmName, "true"),
Config: testAccVmConfigWithDeletionBlocked(vmName, "true"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
Expand All @@ -1787,6 +1804,20 @@ func TestAccXenorchestraVm_createWithV0StateMigration(t *testing.T) {
PlanOnly: true,
ExpectNonEmptyPlan: false,
},
{
ExternalProviders: map[string]resource.ExternalProvider{
"xenorchestra": {
Source: "terra-farm/xenorchestra",
VersionConstraint: "0.25.1",
},
},
Config: testAccVmConfigWithWaitForIp(vmName, "true"),
Check: resource.ComposeAggregateTestCheckFunc(
testAccVmExists(resourceName),
resource.TestCheckResourceAttrSet(resourceName, "id"),
resource.TestCheckResourceAttr(resourceName, "destroy_cloud_config_vdi_after_boot", "false"),
),
},
},
})
}
Expand Down Expand Up @@ -2014,6 +2045,38 @@ func testAccVmConfig(vmName string) string {
return testAccVmConfigWithWaitForIp(vmName, "false")
}

// terraform configuration that can be used to block changes that should not destroy a VM.
// While this doesn't integrate nicely with the sdk's test helpers (failure is vague), there
// are some cases were options are limited (testing pinned provider versions).
func testAccVmConfigWithDeletionBlocked(vmName, waitForIp string) string {
return testAccCloudConfigConfig(fmt.Sprintf("vm-template-%s", vmName), "template") + testAccTemplateConfig() + fmt.Sprintf(`
data "xenorchestra_network" "network" {
name_label = "%s"
pool_id = "%s"
}

resource "xenorchestra_vm" "bar" {
memory_max = 4295000000
cpus = 1
cloud_config = xenorchestra_cloud_config.bar.template
name_label = "%s"
name_description = "description"
template = data.xenorchestra_template.template.id
network {
network_id = data.xenorchestra_network.network.id
}

disk {
sr_id = "%s"
name_label = "disk 1"
size = 10001317888
}
wait_for_ip = %s
blocked_operations = ["destroy"]
}
`, accDefaultNetwork.NameLabel, accTestPool.Id, vmName, accDefaultSr.Id, waitForIp)
}

func testAccVmConfigWithWaitForIp(vmName, waitForIp string) string {
return testAccCloudConfigConfig(fmt.Sprintf("vm-template-%s", vmName), "template") + testAccTemplateConfig() + fmt.Sprintf(`
data "xenorchestra_network" "network" {
Expand Down
Loading