feat(xo-web): ability to block/unblock migration #8129
Conversation
velvetrevolver
force-pushed
the
ability-to-block-migration
branch
from
1a9ec93
to
41daaa7
Compare
stephane-m-dev
changed the title
| @@ -780,6 +784,13 @@ export default class TabAdvanced extends Component { | |||
| labelId='vmWarmMigration' | |||
| tooltip={isWarmMigrationAvailable ? undefined : _('availableXoaPremium')} | |||
| /> | |||
| <TabButton | |||
| btnStyle='warning' | |||
| handler={isMigrationAllowed ? vmBlockMigration : vmAllowMigration} | |||
There was a problem hiding this comment.
As I understand this, it would let users click the "Allow migration" button even when migrations are blocked for another reason (i.e. when vm.blockedOperations.migrate_send === 'another reason than "VM migration is blocked during backup"'), which means clicking the button won't change anything.
Maybe we can gray out the button in such case, or display an information message?
There was a problem hiding this comment.
We don't want to prevent the user from unblocking the migration, even if it has been blocked by the backup.
For instance, there might be an issue with the backup which prevented it from unblocking the operation at then end, and we want users to be able to bypass this.
But I think it would make sense to display the current reason it is blocked before unblocking, maybe by showing a modal (and only if the reason is not trivial, i.e. 'true').
There was a problem hiding this comment.
@julien-f Can we already ship the feature like this, and maybe improve it later?
Or do you want it to be improved now?
There was a problem hiding this comment.
I fear that doing it in two steps will in fact make it more work and take longer.
IMHO that adding a quick confirm should be quick, what do you think @pdonias (of both the idea and how to implement it)?
There was a problem hiding this comment.
I agree. It gives more feedback and doesn't prevent the user from doing anything while keeping it safe. I think a simple confirm modal in vmAllowMigration that shows the reason is enough.
There was a problem hiding this comment.
@pdonias Do you think that someone could help on the front-side?
stephane-m-dev
force-pushed
the
ability-to-block-migration
branch
from
41daaa7
to
330965a
Compare
stephane-m-dev
changed the title
| handlerParam={vm} | ||
| icon='vm-allow-migration' | ||
| labelId={isMigrationAllowed ? 'vmBlockMigration' : 'vmAllowMigration'} | ||
| /> |
There was a problem hiding this comment.
It seems I lost a comment there: use a toggle button like other blocked operations.
What I previously meant is: do not create a function that will switch the state as it can behave strangely if the cache is not up-to-date, the customer should be able to see whether it will block or unblock when clicking on the button.
There was a problem hiding this comment.
That's what I did: I split my toogle function into two different functions, and the button indicates whether it is used to block or unblock (as shown on the screenshots at the top of the PR).
What's wrong for you?
There was a problem hiding this comment.
I want this feature to be displayed the same way other blocked operations are displayed:
There was a problem hiding this comment.
@julien-f OK it's clearer with a picture! I'll change that.
stephane-m-dev
force-pushed
the
ability-to-block-migration
branch
3 times, most recently
from
da1b169
to
12d859b
Compare
stephane-m-dev
force-pushed
the
ability-to-block-migration
branch
from
12d859b
to
4742eaa
Compare
Description
VM : add ability to block / unblock migration
XO-389
https://project.vates.tech/vates-global/projects/70ab2907-1ac3-4e7d-831f-a8752c36474d/issues/b8c25c6d-40ba-4cb6-8a6c-33d887692525
UPDATED : change TabButton to Toggle
UPDATED : add confirm modal on Toggle
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: