Add RemoveByTimestamp RPC #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Deploying with
|
| Latest commit: |
d32d2a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ef7ff80.vald.pages.dev |
| Branch Preview URL: | https://feature-lb-delete-with-times.vald.pages.dev |
github-actions
bot
added
area/internal
team/set
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hlts2
force-pushed
the
feature/lb/delete-with-timestamp
branch
from
2698fe2
to
6786ee9
Compare
| @@ -366,6 +368,579 @@ func Test_server_Remove(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func Test_server_RemoveByTimestamp(t *testing.T) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Function name: Test_server_RemoveByTimestamp, Cyclomatic Complexity: 16, Halstead Volume: 5385.37, Maintainability Index: 19 (maintidx)
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Flb%2Fdelete-with-timestamp/d66f6ed5c2ee969a1726b18db754e42014277814 |
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
force-pushed
the
feature/lb/delete-with-timestamp
branch
from
2af923e
to
aaeac0b
Compare
hlts2
added
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-max-dim
and removed
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-max-dim
labels
Signed-off-by: hlts2 <[email protected]>
vankichi
requested review from
a team and
kpango
and removed request for
kevindiu and
a team
kpango
approved these changes
Aug 31, 2023
datelier
approved these changes
Aug 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have added a new RPC (
RemoveByTimestamp) to remove vectors based on timestamp.The following conditions can be specified multiple times.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: