Fix update deps workflow: buf is not found #2737
Conversation
Signed-off-by: vankichi <[email protected]>
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the workflow file Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/update-deps.yaml (2)
Line range hint
71-77: Fix the version comparison syntax in the shell script.The current version comparison has incorrect syntax which could lead to unexpected behavior:
${LATEST} eq "1.7"is invalid bash syntaxeqis not a valid bash comparison operatorApply this fix:
- if ${LATEST} eq "1.7"; then + if [ "${LATEST}" = "1.7" ]; then
Line range hint
44-54: Consider adding error handling for the dependency update commands.The sequence of make commands could fail silently. Consider adding error checking to ensure each step completes successfully.
Example improvement:
run: | + set -e # Exit on any error make files make update make deps make helm/schema/all # ... rest of commands ...
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/update-deps.yaml(1 hunks)
🔇 Additional comments (1)
.github/workflows/update-deps.yaml (1)
45-45: LGTM! Verify the make deps target exists.
The addition of make deps should help resolve the missing 'buf' tool issue.
Let's verify the existence and implementation of the deps target:
✅ Verification successful
The make deps target exists and is properly implemented
The deps target is defined in the Makefile with the following dependencies:
proto/depsdeps/install
The deps/install target is also defined and installs various development tools:
- crlfmt
- golines
- gofumpt
- strictgoimports
- goimports
This implementation appears correct and complete for handling dependencies.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the make deps target exists and its implementation
# Expected: Find the deps target definition that handles buf installation
# Search for deps target in Makefile
rg -A 5 '^deps:' Makefile
# Search for buf-related commands in Makefiles
rg -g 'Makefile*' 'buf'
Length of output: 301
Script:
#!/bin/bash
# Let's check the implementation of buf/install target and deps/install target
rg -A 5 '^buf/install:' Makefile
rg -A 5 '^deps/install:' Makefile
# Also check the proto/deps target as it's part of the deps dependency chain
rg -A 5 '^proto/deps:' Makefile
Length of output: 224
Script:
#!/bin/bash
# Let's check for buf-related targets with different patterns and more context
rg -g 'Makefile*' -B 2 -A 5 'buf' --context-separator='---'
# Also check if there are any other Makefiles in subdirectories
fd Makefile
Length of output: 730
Script:
#!/bin/bash
# Let's check the content of the other Makefiles and the Makefile.d directory
cat internal/core/algorithm/ngt/Makefile
ls -la Makefile.d/
cat Makefile.d/*
Length of output: 129207
Deploying vald with
|
| Latest commit: |
cefb26a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf3e91ee.vald.pages.dev |
| Branch Preview URL: | https://ci-workflow-fix-ci-error-buf.vald.pages.dev |
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]>
Signed-off-by: vankichi <[email protected]> Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
fix Signed-off-by: kpango <[email protected]>
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit