Skip to content

Conversation

@kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Oct 9, 2025

Description

SSIA

Related Issue

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.24.5
  • Rust Version: v1.88.0
  • Docker Version: v28.3.2
  • Kubernetes Version: v1.33.3
  • Helm Version: v3.18.4
  • NGT Version: v2.4.3
  • Faiss Version: v1.11.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Bug Fixes
    • Ensures Docker manifests are created and pushed for every image tag, not just the primary tag, preventing pull issues with secondary tags.
  • Chores
    • Aligns tag handling across release workflow steps for consistent multi-tag image publishing.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 9, 2025

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The GitHub Action at .github/actions/create-docker-manifest/action.yaml updates the manifest creation loop to use the per-iteration tag variable (tag) instead of the primary tag variable (PRIMARY_TAG), aligning both loops to iterate over all tags from PRIMARY_TAG and EXTRA_TAGS.

Changes

Cohort / File(s) Summary
GitHub Actions: Docker manifest tagging loop
\.github/actions/create-docker-manifest/action.yaml``
In the manifest creation loop, replaced TAG="${PRIMARY_TAG}" with TAG="${tag}" so each iteration uses the current tag. The inspect loop already used TAG="${tag}", making both loops consistent across PRIMARY_TAG and EXTRA_TAGS.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions Runner
  participant SH as Shell Loop
  participant DK as Docker CLI

  GH->>SH: Iterate tags from PRIMARY_TAG + EXTRA_TAGS
  loop for each tag
    note over SH,Dk: Set TAG to current loop variable `tag` (updated)
    SH->>DK: docker manifest create ...:${TAG}
    SH->>DK: docker manifest push ...:${TAG}
    SH->>DK: docker manifest inspect ...:${TAG}
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

type/ci, type/bug, size/S, priority/medium

Suggested reviewers

  • kpango
  • datelier
  • Matts966
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/ci/tag-parameter

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc32bfa and e4a04c3.

📒 Files selected for processing (1)
  • .github/actions/create-docker-manifest/action.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kmrmt kmrmt requested review from a team, Matts966 and kpango and removed request for a team October 9, 2025 05:44
@kpango kpango merged commit b79998d into main Oct 9, 2025
20 checks passed
@kpango kpango deleted the bugfix/ci/tag-parameter branch October 9, 2025 05:45
vdaas-ci pushed a commit that referenced this pull request Oct 9, 2025
Matts966 pushed a commit that referenced this pull request Oct 9, 2025
Co-authored-by: Kosuke Morimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants