Skip to content

Add mempool enpoints #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 23, 2025
Merged

Add mempool enpoints #1035

merged 27 commits into from
Apr 23, 2025

Conversation

YeahNotSewerSide
Copy link
Member

Description

Add mempool endpoints to the REST API

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Added unit tests for the new endpoints

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@YeahNotSewerSide YeahNotSewerSide requested a review from a team as a code owner April 4, 2025 09:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 73.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (77e0426) to head (c7e9c5e).

Files with missing lines Patch % Lines
api/node/node.go 85.71% 10 Missing and 2 partials ⚠️
api/utils/http.go 0.00% 9 Missing ⚠️
cmd/thor/main.go 0.00% 2 Missing ⚠️
txpool/tx_pool.go 33.33% 2 Missing ⚠️
api/api.go 0.00% 1 Missing ⚠️
cmd/thor/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   60.44%   60.48%   +0.04%     
==========================================
  Files         219      219              
  Lines       22778    22876      +98     
==========================================
+ Hits        13768    13837      +69     
- Misses       7914     7940      +26     
- Partials     1096     1099       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@freemanzMrojo freemanzMrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, just left some comments about some suggested changes

freemanzMrojo
freemanzMrojo previously approved these changes Apr 9, 2025
@freemanzMrojo freemanzMrojo dismissed their stale review April 10, 2025 09:22

Requirements changed

Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits - would be nice to fix the receiver mismatch, other comments are smaller things.

@libotony libotony merged commit 3eea2d4 into master Apr 23, 2025
19 checks passed
@libotony libotony deleted the andrew/feat/mempool-enpoints branch April 23, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants